Skip to content

MQE-697: Grab test actions's results cannot be used in action-groups #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 12, 2018
Merged

MQE-697: Grab test actions's results cannot be used in action-groups #51

merged 7 commits into from
Mar 12, 2018

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Mar 12, 2018 •
edited
Loading

Description

  • References to stepkeys ({$someGrabAction} or $persistedDataKey.field) in actionGroups now will automatically append the actionGroup's stepkey
  • ActionObjects now also have an array to store their origin. Only used in actionGroups at the moment.
  • Changed actionGroup key appending to follow camel casing rules.

Fixed Issues (if relevant)

  1. MQE-2047: Jenkins Pipeline - Static Check Options #697: Grab test actions's results cannot be used in action-groups

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-697: Grab test actions's results cannot be used in action-groups
64902cf 
- actionGroup now loops through known keys and replaces references to them with stepKey . actionGroupKey
- added verification tests
@KevinBKozan
MQE-697: Grab test actions's results cannot be used in action-groups
d192c50 
- str_replace usage
@KevinBKozan
MQE-697: Grab test actions's results cannot be used in action-groups
4c94f74 
- added actionGroupOrigin to actionObject, keeps track of which actionGroup it came frmo and the test invocation name.
- testGenerator actionName no longer exists, now passes and uses actionObject where needed.
- replacement of actionGroup key is now done at testgenerator level, not object level.
- updated tests to reflect this
@KevinBKozan
Merge branch 'develop' into MQE-697
eb78ea6
@KevinBKozan
MQE-697: Grab test actions's results cannot be used in action-groups
9fb3a47 
- CR fixes.
@KevinBKozan
MQE-697: Grab test actions's results cannot be used in action-groups
02125db 
- renaming actionGroupOrigin to actionOrigin.
@KevinBKozan
MQE-697: Grab test actions's results cannot be used in action-groups
87dfe87 
- static/verification test fixes.
@KevinBKozan KevinBKozan merged commit 4ec6362 into develop Mar 12, 2018
@KevinBKozan KevinBKozan deleted the MQE-697 branch March 12, 2018 18:03
magento-cicd2 pushed a commit that referenced this pull request May 4, 2021
@jilu1
Merge pull request #51 from magento-commerce/master
6866637 
Master >> develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@KevinBKozan